Fixes the re enabling of RTFCacheConfigMetricsCollector #759
+43
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gagan Juneja <[email protected]>
Gaganjuneja
requested review from
khushbr,
ansjcy,
sbcd90,
Shephalimittal,
nishchay21,
rramachand21 and
psychbot
as code owners
nishchay21
approved these changes
Nov 5, 2024
nishchay21
approved these changes
Nov 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> (cherry picked from commit cdd56a0)
nishchay21
pushed a commit
that referenced
this pull request
Nov 5, 2024
Signed-off-by: Gagan Juneja <[email protected]> Co-authored-by: Gagan Juneja <[email protected]> (cherry picked from commit cdd56a0) Co-authored-by: Gagan Juneja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the case where if RTFCacheConfigMetricsCollector got disabled once and re enabled the Gauge instruments should be recreated.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.